This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Exclude stubbed ProgramCosts column from compaction #18840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
v1.6-compaction-filter
branch
from
67823a9 to
baae46d
Compare
ryoqun
reviewed
Jul 22, 2021
| columns::TransactionStatusIndex::NAME | ||
| )); | ||
| assert!(excludes_from_compaction(columns::ProgramCosts::NAME)); | ||
| assert!(!excludes_from_compaction("something else")); |
I wish this could be type safe... but I'm glad that it crashed hard before rocksdb compaction go berserk, bricking existing ledgers... |
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.6 #18840 +/- ##
=========================================
- Coverage 82.6% 82.2% -0.4%
=========================================
Files 423 422 -1
Lines 116083 118029 +1946
=========================================
+ Hits 95947 97104 +1157
- Misses 20136 20925 +789 |
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Jul 26, 2021
CriesofCarrots
added a commit
that referenced
this pull request
Jul 26, 2021
* backport new column families from master to 1.6 (#18743) * backporting bank_hash and program_costs column families from master to 1.6 for rocksdb backward compatibility * missed a line to allow dead code * include code for purge * Exclude stubbed ProgramCosts column from compaction (#18840) Co-authored-by: Tao Zhu <82401714+taozhu-chicago@users.noreply.github.com>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Booting a v1.6 node with an existing ledger fails on compaction:
The code excluding the ProgramCosts column from compaction wasn't included in #18743 (fyi @taozhu-chicago )
Summary of Changes
Exclude stubbed ProgramCosts column from compaction
cc @joncinque