Fix db ledger keys endianess #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
approved these changes
Nov 22, 2018
carllin
force-pushed
the
FixDbLedgerKeys
branch
from
988927d to
c590b37
Compare
carllin
force-pushed
the
FixDbLedgerKeys
branch
from
c590b37 to
964f0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The default comparator for Rocksdb is a comparator that uses lexicographic byte-wise ordering. This means storing the unsigned integer keys using the current LittleEndian ordering would order larger unsigned integers before smaller unsigned integers when compared byte-wise.
Summary of Changes
Switch LittleEndian to BigEndian when storing keys in DbLedger
Fixes #