Add maximum repair length to db_window #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
reviewed
Nov 22, 2018
src/db_window.rs
Outdated
| max_repair_entry_height - 1, | ||
| MAX_REPAIR_LENGTH, | ||
| ); | ||
| idxs.truncate(MAX_REPAIR_LENGTH); |
There was a problem hiding this comment.
why are you truncating if find_missing is limiting its output?
There was a problem hiding this comment.
oops, I thought I had already removed this, good catch.
rob-solana
reviewed
Nov 22, 2018
src/db_window.rs
Outdated
| @@ -17,6 +17,8 @@ use std::sync::atomic::{AtomicBool, Ordering}; | |||
| use std::sync::{Arc, RwLock}; | |||
| use streamer::BlobSender; | |||
|
|
|||
| pub const MAX_REPAIR_LENGTH: usize = 100; | |||
There was a problem hiding this comment.
can we make this a power of 2?
rob-solana
approved these changes
Nov 22, 2018
carllin
force-pushed
the
AddMaximumRepairLength
branch
from
b71302f to
37cebdc
Compare
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Jul 1, 2024
…-labs#1809) (solana-labs#1886) * Remove support for deprecated rpc endpoints (solana-labs#1809) * Remove rpc_obsolete_v1_7 * Remove rpc_deprecated_v1_7 * Remove rpc_deprecated_v1_9 * Add CHANGELOG entry * Add another CHANGELOG entry (cherry picked from commit 83527d9) # Conflicts: # CHANGELOG.md * Fix conflict --------- Co-authored-by: Tyera <tyera@anza.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The number of repairs could now be potentially unbounded, which causes massive congestion on the network.
Summary of Changes
Limit the number of repairs a node can fire off at once
Fixes #