This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
filters crds values in parallel when responding to gossip pull-requests #18877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
filter-crds-parallel
branch
3 times, most recently
from
a90ead0 to
928f969
Compare
Codecov Report
@@ Coverage Diff @@
## master #18877 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 444 444
Lines 126568 126582 +14
=======================================
+ Hits 104838 104884 +46
+ Misses 21730 21698 -32 |
behzadnouri
force-pushed
the
filter-crds-parallel
branch
from
928f969 to
8de8e2d
Compare
behzadnouri
changed the title
|
Left side is this code, versus current master code on the right.
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2021
…ts (#18877) When responding to gossip pull-requests, filter_crds_values takes a lot of time while holding onto read-lock: https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566 This commit will filter-crds-values in parallel using rayon thread-pools. (cherry picked from commit f1198fc) # Conflicts: # gossip/src/cluster_info.rs # gossip/src/crds_gossip_pull.rs
mergify bot
added a commit
that referenced
this pull request
Jul 26, 2021
…ts (backport #18877) (#18901) * filters crds values in parallel when responding to gossip pull-requests (#18877) When responding to gossip pull-requests, filter_crds_values takes a lot of time while holding onto read-lock: https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566 This commit will filter-crds-values in parallel using rayon thread-pools. (cherry picked from commit f1198fc) # Conflicts: # gossip/src/cluster_info.rs # gossip/src/crds_gossip_pull.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
|
TDS improvement with now 84% of stake upgrading to this code.
|
Closed
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
…ts (#18877) When responding to gossip pull-requests, filter_crds_values takes a lot of time while holding onto read-lock: https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566 This commit will filter-crds-values in parallel using rayon thread-pools. (cherry picked from commit f1198fc) # Conflicts: # core/src/cluster_info.rs # core/src/crds_gossip.rs # core/src/crds_gossip_pull.rs # core/src/gossip_service.rs
behzadnouri
added a commit
that referenced
this pull request
Sep 8, 2021
…ts (#18877) When responding to gossip pull-requests, filter_crds_values takes a lot of time while holding onto read-lock: https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566 This commit will filter-crds-values in parallel using rayon thread-pools. (cherry picked from commit f1198fc)
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2021
…ts (backport #18877) (#19450) * filters crds values in parallel when responding to gossip pull-requests (#18877) When responding to gossip pull-requests, filter_crds_values takes a lot of time while holding onto read-lock: https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566 This commit will filter-crds-values in parallel using rayon thread-pools. (cherry picked from commit f1198fc) * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When responding to gossip pull-requests,
filter_crds_valuestakes a lot of time while holding onto read-lock:https://github.com/solana-labs/solana/blob/f51d64868/gossip/src/crds_gossip_pull.rs#L509-L566
Summary of Changes