This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove filter_snapshot_storages_for_incremental_snapshot() #19349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
changed the title
brooksprumo
force-pushed
the
remove-filter-snapshot-storages
branch
from
4236bb4 to
4a93dba
Compare
Codecov Report
@@ Coverage Diff @@
## master #19349 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 457 457
Lines 130682 130686 +4
=======================================
+ Hits 108306 108317 +11
+ Misses 22376 22369 -7 |
carllin
previously approved these changes
Aug 21, 2021
brooksprumo
force-pushed
the
remove-filter-snapshot-storages
branch
from
4a93dba to
5b73969
Compare
Now that we can get just the subset of snapshot storages we want, the extra filtering afterwards is redundant.
brooksprumo
force-pushed
the
remove-filter-snapshot-storages
branch
from
5b73969 to
2ca39de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that we can get just the subset of snapshot storages we want, the extra filtering afterwards is redundant.
Summary of Changes
Remove calls to
filter_snapshot_storages_for_incremental_snapshot(), and the function itself.Related to #17088