This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Added web3 reference guide #19970
Merged
Added web3 reference guide #19970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cryptogosu is attempting to deploy a commit to the Solana Team on Vercel. A member of the Team first needs to authorize it. |
jacobcreech
force-pushed
the
web3-reference
branch
3 times, most recently
from
c28370e to
686bb68
Compare
jacobcreech
force-pushed
the
web3-reference
branch
from
686bb68 to
ad42e05
Compare
jacobcreech
force-pushed
the
web3-reference
branch
2 times, most recently
from
47fa6ed to
d4cda94
Compare
|
@jstarry Updated all documentation based on your suggestions. |
jstarry
reviewed
Sep 21, 2021
|
|
||
| [Source Documentation](https://solana-labs.github.io/solana-web3.js/classes/NonceAccount.html) | ||
|
|
||
| Normally a transaction is rejected if a transaction's `recentBlockhash` field is too old. To provide for certain custodial services, Nonce Accounts are used. Transactions created by a Nonce Account do not expire because they start with an `AdvanceNonceAccount` instruction, which updates the Nonce Account with an up-to-date `recentBlockhash`. This on-chain `recentBlockhash` is then used in the Nonce Account's transaction. |
There was a problem hiding this comment.
Suggested change
| Normally a transaction is rejected if a transaction's `recentBlockhash` field is too old. To provide for certain custodial services, Nonce Accounts are used. Transactions created by a Nonce Account do not expire because they start with an `AdvanceNonceAccount` instruction, which updates the Nonce Account with an up-to-date `recentBlockhash`. This on-chain `recentBlockhash` is then used in the Nonce Account's transaction. | |
| Normally a transaction is rejected if a transaction's `recentBlockhash` field is too old. To provide for certain custodial services, Nonce Accounts are used. Transactions which use a `recentBlockhash` captured on-chain by a Nonce Account do not expire as long at the Nonce Account is not advanced. |
jstarry
reviewed
Sep 21, 2021
There was a problem hiding this comment.
I wish that the most important classes came first and the others were grouped by category. For example, starting off with Authorized makes it feel that it's a foundational important thing to learn, but it's really just a detail of how the stake program. How about splitting some of these classes into categories like "General", "Staking", etc
Added web3 reference guide Added web3 reference guide
jacobcreech
force-pushed
the
web3-reference
branch
from
d4cda94 to
b9e4855
Compare
|
@jstarry I updated the order and format to have General and Staking. I also removed Let me know what you think about the new format. |
jstarry
approved these changes
Sep 22, 2021
|
Looks much better thanks! |
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Added web3 reference guide Added web3 reference guide (cherry picked from commit b16f2da)
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Oct 9, 2021
Added web3 reference guide Added web3 reference guide
danpaul000
added a commit
that referenced
this pull request
Oct 9, 2021
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
Added web3 reference guide Added web3 reference guide
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit c43a3e1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Web3 was lacking a reference guide, and many ask for it in the support discord
Summary of Changes
Added web3 reference guide to the docs