Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf.mk: Abort make if scripts/install.sh fails #2113

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Conversation

mvines
Copy link
Member

@mvines mvines commented Dec 11, 2018

Makes the error that occurred in solana-labs/example-tictactoe#23 much clearer and easier to debug

@mvines mvines added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Dec 11, 2018
@mvines mvines merged commit 54fb4e3 into solana-labs:master Dec 12, 2018
@mvines mvines deleted the err branch December 19, 2018 22:15
willhickey pushed a commit that referenced this pull request Aug 31, 2024
…n startup (backport of #1971) (#2113)

* blockstore: only consume duplicate proofs from root_slot + 1 on startup (#1971)

* blockstore: only consume duplicate proofs from root_slot + 1 on startup

* pr feedback: update test comments

* pr feedback: add pub behind dcou for test fns

(cherry picked from commit 2a48564)

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <ashwin@anza.xyz>
Co-authored-by: Ashwin Sekar <ashwin@solana.com>
behzadnouri pushed a commit to behzadnouri/solana that referenced this pull request Oct 10, 2024
…n startup (backport of solana-labs#1971) (solana-labs#2113)

* blockstore: only consume duplicate proofs from root_slot + 1 on startup (solana-labs#1971)

* blockstore: only consume duplicate proofs from root_slot + 1 on startup

* pr feedback: update test comments

* pr feedback: add pub behind dcou for test fns

(cherry picked from commit 2a48564)

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <ashwin@anza.xyz>
Co-authored-by: Ashwin Sekar <ashwin@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant