Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Prevent lookup tables from being closed during deactivation slot #22221

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented Jan 2, 2022

Problem

Missing edge case allows address lookup tables to be deactivated and closed in the same slot

Summary of Changes

  • Prevent lookup tables from being closed in the same slot in which they were deactivated

Fixes #

@jstarry jstarry force-pushed the fix-address-table-deactivation branch from 3dd6657 to cec362a Compare January 2, 2022 03:47
@jstarry jstarry force-pushed the fix-address-table-deactivation branch from cec362a to 4c05f76 Compare January 2, 2022 03:59
@jstarry jstarry force-pushed the fix-address-table-deactivation branch from 4c05f76 to 7bd219f Compare January 2, 2022 05:20
@jstarry jstarry added the v1.9 label Jan 2, 2022
@jstarry jstarry requested a review from joncinque January 2, 2022 05:22
@jstarry jstarry marked this pull request as ready for review January 2, 2022 05:22
@jstarry jstarry force-pushed the fix-address-table-deactivation branch from 7bd219f to 75a294c Compare January 2, 2022 08:19
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #22221 (75a294c) into master (d6ec103) will increase coverage by 0.0%.
The diff coverage is 73.7%.

@@           Coverage Diff           @@
##           master   #22221   +/-   ##
=======================================
  Coverage    81.0%    81.0%           
=======================================
  Files         523      523           
  Lines      146497   146551   +54     
=======================================
+ Hits       118741   118793   +52     
- Misses      27756    27758    +2     

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jstarry jstarry merged commit bbe5b66 into solana-labs:master Jan 3, 2022
mergify bot pushed a commit that referenced this pull request Jan 3, 2022
mergify bot added a commit that referenced this pull request Jan 3, 2022
) (#22247)

(cherry picked from commit bbe5b66)

Co-authored-by: Justin Starry <justin@solana.com>
@jstarry jstarry deleted the fix-address-table-deactivation branch January 5, 2022 00:29
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants