Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime support for address table lookups #22223

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jan 2, 2022

Summary of Changes

This is an incremental change to supporting dynamic address loading for transactions that make use of address table lookups. This change stops short of allowing processed versioned transactions from being persisted to blockstore. That change will come in a follow up PR.

  • Add gated support for dynamically loading addresses for v0 transactions from lookup tables in accounts db
  • Implemented address lookups in AddressLookupTable state accounts

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #22223 (0c48805) into master (08e64c8) will decrease coverage by 0.0%.
The diff coverage is 77.4%.

@@            Coverage Diff            @@
##           master   #22223     +/-   ##
=========================================
- Coverage    81.1%    81.0%   -0.1%     
=========================================
  Files         551      551             
  Lines      149828   150085    +257     
=========================================
+ Hits       121522   121695    +173     
- Misses      28306    28390     +84     

@jstarry jstarry force-pushed the address-table-lookups branch from e3a3e31 to 8b3f258 Compare January 3, 2022 11:43
@jstarry jstarry force-pushed the address-table-lookups branch from 8b3f258 to 6eb62bf Compare January 3, 2022 21:59
@jstarry jstarry added the v1.9 label Jan 3, 2022
@jstarry jstarry force-pushed the address-table-lookups branch 2 times, most recently from 67104ef to 36e5929 Compare January 3, 2022 22:15
@jstarry jstarry marked this pull request as ready for review January 3, 2022 22:20
@jstarry jstarry requested review from jackcmay and joncinque January 3, 2022 22:21
@jstarry jstarry force-pushed the address-table-lookups branch 2 times, most recently from a09d84c to 4c6f9f2 Compare January 4, 2022 10:47
joncinque
joncinque previously approved these changes Jan 5, 2022
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Mainly a few questions, nothing that should stop this going forward though

core/src/banking_stage.rs Show resolved Hide resolved
sdk/program/src/message/versions/mod.rs Show resolved Hide resolved
programs/address-lookup-table/src/state.rs Show resolved Hide resolved
sdk/src/transaction/sanitized.rs Outdated Show resolved Hide resolved
runtime/src/message_processor.rs Show resolved Hide resolved
@jstarry jstarry force-pushed the address-table-lookups branch from 91cf5bb to 7ac2e3c Compare January 6, 2022 14:16
@mergify mergify bot dismissed joncinque’s stale review January 6, 2022 14:17

Pull request has been modified.

@jstarry jstarry force-pushed the address-table-lookups branch from 7ac2e3c to dce2c73 Compare January 6, 2022 15:09
joncinque
joncinque previously approved these changes Jan 6, 2022
@mergify mergify bot dismissed joncinque’s stale review January 7, 2022 01:42

Pull request has been modified.

@jstarry jstarry merged commit 52d12cc into solana-labs:master Jan 7, 2022
mergify bot pushed a commit that referenced this pull request Jan 7, 2022
* Add support for address table lookups in runtime

* feedback

* feedback

(cherry picked from commit 52d12cc)

# Conflicts:
#	accountsdb-plugin-postgres/scripts/create_schema.sql
#	runtime/src/accounts.rs
#	runtime/src/bank.rs
#	runtime/src/message_processor.rs
@jstarry
Copy link
Member Author

jstarry commented Jan 7, 2022

@jackcmay it'd still be nice to get your eyes on this if you can find the time, I merged to get a dependent change up for review

@jstarry jstarry deleted the address-table-lookups branch January 7, 2022 03:59
@jackcmay
Copy link
Contributor

jackcmay commented Jan 7, 2022

I started working it and got multiple interrupts, will return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants