This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Send events to the right address #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
fix_events_addr
branch
2 times, most recently
from
a1fcf87 to
61178f1
Compare
garious
reviewed
May 22, 2018
src/thin_client.rs
Outdated
| pub addr: SocketAddr, | ||
| pub requests_socket: UdpSocket, | ||
| pub events_socket: UdpSocket, | ||
| addr: SocketAddr, |
There was a problem hiding this comment.
rename that to requests_addr?
garious
reviewed
May 22, 2018
src/thin_client.rs
Outdated
| addr: SocketAddr, | ||
| requests_socket: UdpSocket, | ||
| events_socket: UdpSocket, | ||
| events_addr: SocketAddr, |
There was a problem hiding this comment.
Put that before events_socket so that it's consistent with the requests addr/socket pair?
garious
reviewed
May 22, 2018
src/thin_client.rs
Outdated
| @@ -27,11 +28,17 @@ impl ThinClient { | |||
| /// Create a new ThinClient that will interface with Rpu | |||
| /// over `requests_socket` and `events_socket`. To receive responses, the caller must bind `socket` | |||
| /// to a public address before invoking ThinClient methods. | |||
| pub fn new(addr: SocketAddr, requests_socket: UdpSocket, events_socket: UdpSocket) -> Self { | |||
| pub fn new( | |||
| addr: SocketAddr, | |||
There was a problem hiding this comment.
Same here, requests_addr and reorder the events args.
garious
reviewed
May 22, 2018
| @@ -152,6 +158,22 @@ impl ThinClient { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
No need to guard this with #[cfg(test)]. This is useful!
garious
reviewed
May 22, 2018
src/bin/client-demo.rs
Outdated
| @@ -148,7 +154,13 @@ fn main() { | |||
| let requests_port = events_addr.port(); | |||
| events_addr.set_port(requests_port + 1); | |||
| let events_socket = UdpSocket::bind(&events_addr).unwrap(); | |||
There was a problem hiding this comment.
This doesn't seem right. You want to bind to the same address you're going to send_to?
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Mar 18, 2024
…ion installation (solana-labs#234) * feat: check user's permissions in Windows * feat: Remove check fun and check os_err * fmt and optimize code
willhickey
pushed a commit
that referenced
this pull request
Mar 20, 2024
…ion installation (#234) * feat: check user's permissions in Windows * feat: Remove check fun and check os_err * fmt and optimize code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.