-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tvu cleanup2 #241
Merged
Merged
Tvu cleanup2 #241
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f3637f2
cleanup
aeyakovenko abfae92
cleanup
aeyakovenko 83036cb
refactor wip
aeyakovenko 6f4e2c1
wip
aeyakovenko e1f1ca2
woop
aeyakovenko dc86529
fmt
aeyakovenko 835e115
@garious review
aeyakovenko b4af525
fmt
aeyakovenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,13 +11,14 @@ use std::sync::atomic::AtomicBool; | |
use std::thread::JoinHandle; | ||
use std::time::Duration; | ||
use tpu::Tpu; | ||
use tvu::Tvu; | ||
|
||
pub struct Server { | ||
pub thread_hdls: Vec<JoinHandle<()>>, | ||
} | ||
|
||
impl Server { | ||
pub fn new<W: Write + Send + 'static>( | ||
pub fn leader<W: Write + Send + 'static>( | ||
bank: Bank, | ||
start_hash: Hash, | ||
tick_duration: Option<Duration>, | ||
|
@@ -26,28 +27,51 @@ impl Server { | |
events_socket: UdpSocket, | ||
broadcast_socket: UdpSocket, | ||
respond_socket: UdpSocket, | ||
gossip: UdpSocket, | ||
gossip_socket: UdpSocket, | ||
exit: Arc<AtomicBool>, | ||
writer: W, | ||
) -> Self { | ||
let bank = Arc::new(bank); | ||
let mut thread_hdls = vec![]; | ||
let rpu = Rpu::new(bank.clone(), requests_socket, respond_socket, exit.clone()); | ||
thread_hdls.extend(rpu.thread_hdls); | ||
|
||
let tpu = Tpu::new( | ||
bank.clone(), | ||
start_hash, | ||
tick_duration, | ||
me, | ||
events_socket, | ||
broadcast_socket, | ||
gossip, | ||
gossip_socket, | ||
exit.clone(), | ||
writer, | ||
); | ||
thread_hdls.extend(tpu.thread_hdls); | ||
|
||
Server { thread_hdls } | ||
} | ||
pub fn validator( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you rename that to |
||
bank: Bank, | ||
me: ReplicatedData, | ||
requests_socket: UdpSocket, | ||
respond_socket: UdpSocket, | ||
replicate_socket: UdpSocket, | ||
gossip_socket: UdpSocket, | ||
leader_repl_data: ReplicatedData, | ||
exit: Arc<AtomicBool>, | ||
) -> Self { | ||
let bank = Arc::new(bank); | ||
let mut thread_hdls = vec![]; | ||
let rpu = Rpu::new(bank.clone(), requests_socket, respond_socket, exit.clone()); | ||
thread_hdls.extend(rpu.thread_hdls); | ||
let tvu = Tvu::new( | ||
bank.clone(), | ||
me, | ||
gossip_socket, | ||
replicate_socket, | ||
leader_repl_data, | ||
exit.clone(), | ||
); | ||
thread_hdls.extend(tvu.thread_hdls); | ||
Server { thread_hdls } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename that to
new_leader
?