Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

chore: delete unused Rollup config in web3.js test dir #24733

Merged
merged 1 commit into from
Apr 27, 2022
Merged

chore: delete unused Rollup config in web3.js test dir #24733

merged 1 commit into from
Apr 27, 2022

Conversation

steveluscher
Copy link
Contributor

We don't need this any longer, right @jstarry?

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #24733 (e528ad3) into master (8ba003a) will decrease coverage by 11.7%.
The diff coverage is n/a.

❗ Current head e528ad3 differs from pull request most recent head b583027. Consider uploading reports for the commit b583027 to get more accurate results

@@             Coverage Diff             @@
##           master   #24733       +/-   ##
===========================================
- Coverage    81.8%    70.0%    -11.8%     
===========================================
  Files         632       37      -595     
  Lines      167499     2301   -165198     
  Branches      322      325        +3     
===========================================
- Hits       137169     1613   -135556     
+ Misses      30217      573    -29644     
- Partials      113      115        +2     

@jstarry
Copy link
Contributor

jstarry commented Apr 27, 2022

This used to be for browser tests, did those get deleted? They were handy for avoiding browser breakage

@steveluscher
Copy link
Contributor Author

Looks like it. That means I should also strip out puppeteer from the deps in this PR.

@jstarry
Copy link
Contributor

jstarry commented Apr 27, 2022

Looks like it. That means I should also strip out puppeteer from the deps in this PR.

Wow, what kind of person just comes around and temporarily removes tests and never adds them back 😠

That means I should also strip out puppeteer from the deps in this PR.

Sounds good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants