Do not hold vote_state lock guard in match statement #25094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
commented
May 9, 2022
| let vote_state = vote_account | ||
| .vote_state() | ||
| .as_ref() | ||
| .map_err(|_| { |
There was a problem hiding this comment.
Does using map_err here actually release the lock?
There was a problem hiding this comment.
I would say yes because map_err consumes self
|
I don't think this usage is problematic, probably not worth fixing just to address the lint warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
vote_statelock guard is held in a match statement. Refer to #24836 for more info, and #24836 (comment) for the clippy output pertaining to this PR.Summary of Changes
Do not hold
vote_statelock guard in match scrutinee.