Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

fix: remove @solana/buffer-layout-utils to fix circular dependency build issues #25399

Merged
merged 1 commit into from
May 20, 2022

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented May 20, 2022

Problem

There's a circular dependency from @solana/web3.js -> @solana/buffer-layout-utils -> @solana/web3.js. Also, apps are seeing compile errors due to @solana/buffer-layout-utils using an esm style import to import from @solana/web3.js when they their @solana/web3.js dependency is not an esm module (solana-labs/buffer-layout-utils#6)

Summary of Changes

  • Copy bigint implementation from @solana/buffer-layout-utils
  • Remove @solana/buffer-layout-utils dependency

Fixes #

Verified

This commit was signed with the committer’s verified signature. The key has expired.
universalmind303 Cory Grinstead
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #25399 (f9c0a32) into master (30e8991) will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #25399     +/-   ##
=========================================
+ Coverage    75.1%    75.3%   +0.2%     
=========================================
  Files          38       39      +1     
  Lines        2314     2337     +23     
  Branches      335      335             
=========================================
+ Hits         1739     1761     +22     
  Misses        459      459             
- Partials      116      117      +1     

@jstarry jstarry changed the title fix: remove dependency on @solana/buffer-layout-utils fix: remove @solana/buffer-layout-utils to fix circular dependency build issues May 20, 2022
@jstarry jstarry merged commit 14b1434 into solana-labs:master May 20, 2022
@jstarry jstarry deleted the web3/remove-buffer-layout-utils branch May 20, 2022 09:57
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
)
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
universalmind303 Cory Grinstead
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant