Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Change WaitableCondvar's mutex to hold () #25857

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Change WaitableCondvar's mutex to hold () #25857

merged 1 commit into from
Jun 9, 2022

Conversation

brooksprumo
Copy link
Contributor

Problem

WaitableCondvar has a mutex so it can use Condvar, but doesn't need a value. It stores a u8, but doesn't need to.

Summary of Changes

Change what the mutex holds to nothing, i.e. the unit type: ().

@brooksprumo brooksprumo marked this pull request as ready for review June 9, 2022 12:14
@brooksprumo brooksprumo requested a review from HaoranYi June 9, 2022 12:14
HaoranYi
HaoranYi approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@brooksprumo brooksprumo merged commit e5f36aa into solana-labs:master Jun 9, 2022
@brooksprumo brooksprumo deleted the waitable-condvar branch June 9, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @HaoranYi