Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of this PR changed. See the discussion (and #26207 (comment) for more info).
Problem
Original:
Clippy was warning about
temporary with significant drop in match scrutinee
for a bunch of uses ofVoteAccounts::vote_state()
. These locks are all reader locks, and there will never be another writer (since the one was within aOnce
), so the clippy warnings are safe to ignore.See #26207 (comment) for more info.
Related to #24836
Actual:
No problem, just an opportunity to refactor 😐
Summary of Changes
Use
VoteAccount::node_pubkey()
when possible.