Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Remove bank test_max_accounts_data_size_exceeded() #26772

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Remove bank test_max_accounts_data_size_exceeded() #26772

merged 1 commit into from
Aug 5, 2022

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jul 25, 2022 •
edited
Loading

Problem

The accounts data size total limit will not be checked per instruction, so no instruction error will be thrown. When that change occurs, this test will no longer be useful/needed. Tests to the check the total accounts data size will be moved to ReplayStage.

See #26744 for full set of changes.

Part of #26439.

Summary of Changes

Remove test_max_accounts_data_size_exceeded()

@brooksprumo brooksprumo marked this pull request as ready for review July 25, 2022 18:38
@brooksprumo brooksprumo requested review from jstarry and Lichtso July 25, 2022 18:39
@brooksprumo
Copy link
Contributor Author

@jstarry @Lichtso Adding y'all as reviewers. There will be a few more similar PRs in prep for moving all the accounts data size stuffs into the final spots.

@brooksprumo
Copy link
Contributor Author

@Lichtso @jstarry Let me know if you'd like to personally review this, or if you're OK with me asking other folks to review. Thanks!

Lichtso
Lichtso approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@Lichtso Lichtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this PR to the description of #26744 so that we can later verify that all test cases are covered again.

This was referenced Aug 5, 2022
Closed
Closed
@brooksprumo brooksprumo merged commit 06a6101 into solana-labs:master Aug 5, 2022
@brooksprumo brooksprumo deleted the accounts-data-len/remove-bank-test_max_accounts_data_size_exceeded branch August 5, 2022 13:55
@brooksprumo brooksprumo linked an issue Aug 5, 2022 that may be closed by this pull request
Enforcing max account data cap may introduce indeterminism #26439
Closed
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
@brooksprumo @xiangzhu70
Remove bank test_max_accounts_data_size_exceeded() (solana-labs#26772)
b51a836 
bank: remove test_max_accounts_data_size_exceeded()
@brooksprumo brooksprumo mentioned this pull request Aug 26, 2022
Closed
7 tasks
@scalalang2 scalalang2 mentioned this pull request Aug 31, 2022
Closed
@brooksprumo brooksprumo mentioned this pull request Mar 1, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lichtso Lichtso Lichtso approved these changes

@jstarry jstarry Awaiting requested review from jstarry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforcing max account data cap may introduce indeterminism
2 participants
@brooksprumo @Lichtso