This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Remove total_data_size and data_size_changed from ExecuteDetailsTimings
#27051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
reviewed
Aug 10, 2022
|
Depends on what you think the expected behavior is. The implementation in this PR would effectively ignore all executable accounts, because the placeholders are empty (so they are counted by don't contribute). Only the first executable account in each executable chain is referenced in the message keys. |
|
These stats were added quite awhile ago by @jeffwashington in #15638. Maybe we can remove them ( |
fine by me |
…d by number_of_message_accounts, ignoring all the redundant executable accounts which were loaded behind that.
…ionRecord by number_of_message_accounts, ignoring all the redundant executable accounts which were loaded behind that." 04fac50
Lichtso
force-pushed
the
fix/execution_record_limit_by_message_accounts
branch
2 times, most recently
from
ce77a7a to
09d4b2f
Compare
Lichtso
force-pushed
the
fix/execution_record_limit_by_message_accounts
branch
from
09d4b2f to
9a51caf
Compare
jstarry
approved these changes
Aug 22, 2022
Lichtso
changed the title
ExecutionRecord by number_of_message_accountstotal_data_size and data_size_changed from ExecuteDetailsTimings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #26990
Summary of Changes
Removes
total_data_sizeanddata_size_changedfromExecuteDetailsTimings.Fixes #26990
follow-up to: #25899