This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Fix test_bench_tps_local_cluster_solana #27448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
previously approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Ah, that makes sense. Might fix some of the other tests we had to ignore as well...
@pgarg66 , can you think of any reason not to make this change?
|
The change makes sense. It's similar to the fix for local-cluster tests (1aa8e06). |
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
… fixed by this change)
…cally but fails in CI
|
This change fixes six of the broken tests. I have updated the issues |
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
* Fix test_bench_tps_local_cluster_solana * Remove #[ignore] annotations from dos tests (which are also fixed by this change) * Remove #[ignore] annotations from local cluster tests (which are also fixed by this change) (cherry picked from commit 4aa2a42)
mergify bot
added a commit
that referenced
this pull request
Aug 30, 2022
Fix test_bench_tps_local_cluster_solana (#27448) * Fix test_bench_tps_local_cluster_solana * Remove #[ignore] annotations from dos tests (which are also fixed by this change) * Remove #[ignore] annotations from local cluster tests (which are also fixed by this change) (cherry picked from commit 4aa2a42) Co-authored-by: Will Hickey <will.hickey@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Enabling quic by default broke multiple tests. See issues #27160 and #27165
Summary of Changes
Bind to 127.0.0.1 instead of 0.0.0.0