RPC: include resolved keys from table lookups in parsed message response #27552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
rpc/parsed-message
branch
from
3a209fb to
f3bf8f9
Compare
mergify bot
added a commit
that referenced
this pull request
Sep 7, 2022
…nse (backport #27552) (#27609) RPC: include resolved keys from table lookups in parsed message response (#27552) * RPC: include resolved keys from table lookups in parsed message response * Add source to ParsedAccount * Ensure that rpc client can parse account meta from old api versions (cherry picked from commit c620b7b) Co-authored-by: Justin Starry <justin@solana.com>
mergify bot
added a commit
that referenced
this pull request
Sep 7, 2022
…nse (backport #27552) (#27610) RPC: include resolved keys from table lookups in parsed message response (#27552) * RPC: include resolved keys from table lookups in parsed message response * Add source to ParsedAccount * Ensure that rpc client can parse account meta from old api versions (cherry picked from commit c620b7b) Co-authored-by: Justin Starry <justin@solana.com>
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
jsonParsedencoded response for versioned transactions and blocks doesn't include account keys resolved from lookup tables in the parsed message account keys list. I consider this a bug because the parsed message response is meant to be a user-friendly response which indicates all the account keys and whether they were writable or signers.Summary of Changes
sourcefield toParsedAccountto indicate whether the account key came from a transaction or lookup tableFixes #