This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
RPC: Support versioned txs in getFeeForMessage API #28217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
fix/fee-for-message
branch
from
134113a to
04495f4
Compare
CriesofCarrots
approved these changes
Oct 4, 2022
Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
* RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/rpc_client.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2022
…28221) * RPC: Support versioned txs in getFeeForMessage API (#28217) * RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/rpc_client.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs * resolve conflicts Co-authored-by: Justin Starry <justin@solana.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
* RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # programs/address-lookup-table/src/error.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
* RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # programs/address-lookup-table/src/error.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs
65 tasks
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
…28256) * RPC: Support versioned txs in getFeeForMessage API (#28217) * RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # programs/address-lookup-table/src/error.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs * resolve conflicts * fix bad conflict resolution Co-authored-by: Justin Starry <justin@solana.com>
mergify bot
added a commit
that referenced
this pull request
Oct 6, 2022
…28257) * RPC: Support versioned txs in getFeeForMessage API (#28217) * RPC: Support versioned txs in getFeeForMessage API * Update sdk/program/src/message/sanitized.rs Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <teulberg@gmail.com> (cherry picked from commit ddf95c1) # Conflicts: # client/src/nonblocking/rpc_client.rs # client/src/rpc_client.rs # programs/address-lookup-table/src/error.rs # rpc/src/rpc.rs # runtime/src/bank/address_lookup_table.rs # sdk/src/transaction/sanitized.rs * resolve conflicts * fix bad conflict resolution Co-authored-by: Justin Starry <justin@solana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getFeeForMessageRPC API and the equivalent RPC client methodget_fee_for_messageboth do not support versioned messages yet.Summary of Changes
getFeeForMessageRPC APISerializableMessagetrait in theget_fee_for_messageRPC client apiAddressLoaderto make it usable insidesolana-programFixes #28182
Fixes #28214