-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace zeros comments with ones #28372
docs: replace zeros comments with ones #28372
Conversation
The original comment is arguably correct. While the base58-encoded string representation of the default PublicKey is all ones, the underlying |
@CriesofCarrots yeah! Thanks for the quick reply and helpful comment. What do you think? |
Codecov Report
@@ Coverage Diff @@
## master #28372 +/- ##
=========================================
+ Coverage 77.3% 77.5% +0.1%
=========================================
Files 55 55
Lines 2889 2926 +37
Branches 402 407 +5
=========================================
+ Hits 2234 2268 +34
- Misses 514 517 +3
Partials 141 141 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick edit! Looks good to me.
(Disregard the commitlint CI failure. I'll fix that on merge/squash)
Documentation describes PublicKey.default as "all zeros" when its in fact, "all ones"