Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ci: build ios and android in our stable and nightly #28761

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

yihau
Copy link
Contributor

@yihau yihau commented Nov 7, 2022

Problem

actions-rs/cargo doesn't maintain for a long time. I would like to get rid of it.

Summary of Changes

  • separate ios and android into different jobs
  • build them with our stable and nightly version
  • use Github Actions built-in NDK version. (r25)
  • trigger pipeline when ci/rust-version.sh changed

- name: Stable build
run: ./cargo stable ndk --target ${{ matrix.target }} build -p solana-client

- name: Nightly build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable is probably sufficient actually, could remove the nightly imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. Thank you!

@yihau yihau merged commit 43e5c18 into solana-labs:master Nov 9, 2022
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Nov 16, 2022
* ci: build ios and android in our stable and nightly

* lint

* only build with stable version

* run client-targets build when push master
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
* ci: build ios and android in our stable and nightly

* lint

* only build with stable version

* run client-targets build when push master
@yihau yihau deleted the github-action-client-traget branch July 17, 2024 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants