Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: local-cluster: Enable test_votes_land_in_fork_during_long_partition #28970

Closed
wants to merge 1 commit into from
Closed

test: local-cluster: Enable test_votes_land_in_fork_during_long_partition #28970

wants to merge 1 commit into from

Conversation

ilya-bobyr
Copy link
Contributor

Problem

tests/local_cluster.rs::test_votes_land_in_fork_during_long_partition has been broken by Enable QUIC client by default. Add arg to disable QUIC client. Take 2.

Summary of changes

Re-enabled the test, it is passing now.

@mergify mergify bot added the community Community contribution label Nov 29, 2022
@mergify mergify bot requested a review from a team November 29, 2022 03:03
@ilya-bobyr ilya-bobyr marked this pull request as ready for review November 29, 2022 03:07
@CriesofCarrots CriesofCarrots added CI Pull Request is ready to enter CI and removed community Community contribution labels Dec 6, 2022
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 6, 2022
@mergify mergify bot added the community Community contribution label Dec 6, 2022
@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Jan 4, 2023
@CriesofCarrots CriesofCarrots removed the community Community contribution label Jan 10, 2023
@brooksprumo brooksprumo removed the request for review from a team January 11, 2023 23:09
@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Jan 27, 2023
@github-actions github-actions bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Feb 14, 2023
@ilya-bobyr
test: local-cluster: Enable test_votes_land_in_fork_during_long_parti…
14ec9e9 
…tion

Test is passing now.  It has been broken by

  Enable QUIC client by default. Add arg to disable QUIC client. Take 2
  #26927

but was fixed since then.
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Mar 3, 2023
@github-actions github-actions bot closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilya-bobyr @CriesofCarrots @solana-grimes