This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: pretty print PublicKey objects in node and in the browser #29062
Merged
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:pretty-print-pubkey
Dec 9, 2022
Merged
fix: pretty print PublicKey objects in node and in the browser #29062
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:pretty-print-pubkey
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll have to double check that this doesn't narrow our browser compatibility too much (eg. for browsers that are missing |
Codecov Report
@@ Coverage Diff @@
## master #29062 +/- ##
=========================================
- Coverage 76.8% 76.7% -0.1%
=========================================
Files 55 55
Lines 3127 3141 +14
Branches 466 472 +6
=========================================
+ Hits 2403 2411 +8
- Misses 559 565 +6
Partials 165 165 |
Tested in React Native 0.70 with Hermes. Works fine. Symbol is supported all the way back to 2015 in major browsers. Shipping it. |
steveluscher
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Dec 9, 2022
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Dec 9, 2022
automerge label removed due to a CI failure |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
console.log(publicKey)
is unreadable in Node.Summary of Changes
Add an object stringifier that includes the base58 string.
Test plan
Node
Browser
Fixes #20022.