test: local-cluster: Fix test_local_cluster_signature_subscribe #29094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
added
CI
github-actions
bot
added
stale
When `add_validator_listener` is invoked, it explicitly sets `is_listener` in the `do_add_validator` call, which in turn means that the `stake` value is ignored. And when a validator has no state, it's voting key does not matter. So, it seems safer to remove both `state` and `voting_keypair` arguments from the `add_validator_listener()`.
Avoid a race condition, and make sure we check for the `RpcSignatureResult::ReceivedSignature`.
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tests/local_cluster.rs::test_local_cluster_signature_subscribehas been broken by Enable QUIC client by default. Add arg to disable QUIC client. Take 2.Seems like it contains a race condition, as it is expecting to see
RpcSignatureResult::ReceivedSignaturewhile connected to a voting validator.Summary of Changes
Added an RPC listener into the cluster created by the test, and switched the RPC subscription to interact with the listner.