Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toolchain file usage #29370

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Add toolchain file usage #29370

merged 5 commits into from
Jan 17, 2023

Conversation

KirillLykov
Copy link
Contributor

@KirillLykov KirillLykov commented Dec 22, 2022 •
edited
Loading

Problem

Spin off PR for #27018
Replacing ./cargo with cargo where it is possible

Summary of Changes

There are two commits:

@KirillLykov KirillLykov mentioned this pull request Dec 22, 2022
Closed
@KirillLykov KirillLykov force-pushed the add_toolchain_file_usage branch 2 times, most recently from 357c2e7 to d48e06e Compare December 28, 2022 00:57
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 11, 2023
@KirillLykov KirillLykov force-pushed the add_toolchain_file_usage branch from d48e06e to 26e9188 Compare January 16, 2023 16:19
@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 17, 2023
yihau
yihau approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes should be good cuz we have already introduced rust-toolchain.toml 🤞

joncinque
joncinque approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@KirillLykov KirillLykov merged commit 8daed75 into solana-labs:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihau yihau yihau approved these changes

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KirillLykov @joncinque @yihau