Revert "Cap accounts data a transaction can load by its requested limit" #29373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
stale
tao-stones
force-pushed
the
revert-27840-limit-accounts-data-size-by-requested-cu
branch
from
33987a2 to
75d0a11
Compare
tao-stones
force-pushed
the
revert-27840-limit-accounts-data-size-by-requested-cu
branch
from
75d0a11 to
4690474
Compare
tao-stones
removed
the
stale
|
After I finish #29728 I should be able to simplify transaction loading in runtime/src/accounts.rs as well and get rid of the duplicate program / executable accounts. That should make your reimplementation of the account size limit also a lot easier. |
Lichtso
approved these changes
Jan 16, 2023
Lichtso
deleted the
revert-27840-limit-accounts-data-size-by-requested-cu
branch
Thanks for review and merge. It's great to simply accounts loading. I have a PR in pipeline to add a fixed data cap loading accounts. Perhaps I should wait tll #29728 lands? |
|
Yes, would be better if you based your work on top of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#27840 was too complex for backporting; and its review before merge to Master is too light. Going to revert it, then break it down to smaller PRs.
Summary of Changes
Reverts #27840