Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recovers merkle roots from shreds binary in {verify,sign}_shreds_gpu (backport #29445) #29877

Merged
merged 2 commits into from
Jan 25, 2023
Merged

recovers merkle roots from shreds binary in {verify,sign}_shreds_gpu (backport #29445) #29877

merged 2 commits into from
Jan 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 24, 2023

This is an automatic backport of pull request #29445 done by Mergify.
Cherry-pick of 9db2565 has failed:

On branch mergify/bp/v1.14/pr-29445
Your branch is up to date with 'origin/v1.14'.

You are currently cherry-picking commit 9db25655f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ledger/src/shred.rs
	modified:   ledger/src/shred/merkle.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ledger/src/sigverify_shreds.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@behzadnouri @mergify
recovers merkle roots from shreds binary in {verify,sign}_shreds_gpu (#…
5578eaa 
…29445)

{verify,sign}_shreds_gpu need to point to offsets within the packets for
the signed data. For merkle shreds this signed data is the merkle root
of the erasure batch and this would necessitate embedding the merkle
roots in the shreds payload.
However this is wasteful and reduces shreds capacity to store data
because the merkle root can already be recovered from the encoded merkle
proof.

Instead of pointing to offsets within the shreds payload, this commit
recovers merkle roots from the merkle proofs and stores them in an
allocated buffer. {verify,sign}_shreds_gpu would then point to offsets
within this new buffer for the respective signed data.

This would unblock us from removing merkle roots from shreds payload
which would save capacity to send more data with each shred.

(cherry picked from commit 9db2565)

# Conflicts:
#	ledger/src/sigverify_shreds.rs
@mergify mergify bot added the conflicts label Jan 24, 2023
@behzadnouri behzadnouri removed their assignment Jan 25, 2023
@behzadnouri behzadnouri merged commit 733e510 into v1.14 Jan 25, 2023
@behzadnouri behzadnouri deleted the mergify/bp/v1.14/pr-29445 branch January 25, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behzadnouri behzadnouri behzadnouri approved these changes

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behzadnouri