This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Report correct transaction_count after squash #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #3000 +/- ##
========================================
+ Coverage 70.7% 76.6% +5.9%
========================================
Files 128 128
Lines 21353 19695 -1658
========================================
+ Hits 15101 15103 +2
+ Misses 6252 4592 -1660 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3000 +/- ##
========================================
+ Coverage 70.7% 76.6% +5.9%
========================================
Files 128 128
Lines 21353 19695 -1658
========================================
+ Hits 15101 15103 +2
+ Misses 6252 4592 -1660 |
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Sep 27, 2024
Cleanup of external_internal_function_hash_collision.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The transaction count reported for the parent forks are incorrect after the child fork is squashed.
Summary of Changes
The parent forks were being removed from the forks list when being squashed and hence the transaction count was being reported as 0 for all the parents. Do not remove the parent forks from the list when squashed.
Fixes #2996