Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove executors trait and replace with LoadedProgram #30348

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Remove executors trait and replace with LoadedProgram #30348

merged 6 commits into from
Feb 17, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Feb 15, 2023

Problem

The executor trait and implementations are being replaced with LoadedProgram. The loader and bank code needs update.

Summary of Changes

Updated code to remove the trait, and its implementations. Replaced with LoadedProgram.

Fixes #

@pgarg66 pgarg66 force-pushed the remove-executors branch 6 times, most recently from 7344931 to 5c6a85f Compare February 16, 2023 13:27
@pgarg66 pgarg66 requested a review from Lichtso February 16, 2023 13:29
@pgarg66 pgarg66 marked this pull request as ready for review February 16, 2023 13:29
Lichtso
Lichtso reviewed Feb 16, 2023
View reviewed changes
programs/bpf_loader/src/lib.rs Outdated Show resolved Hide resolved
program-runtime/src/loaded_programs.rs Show resolved Hide resolved
programs/bpf_loader/src/lib.rs Outdated Show resolved Hide resolved
programs/bpf_loader/src/lib.rs Outdated Show resolved Hide resolved
program-runtime/src/executor_cache.rs Outdated Show resolved Hide resolved
@pgarg66 pgarg66 requested a review from Lichtso February 16, 2023 18:58
Lichtso
Lichtso reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Lichtso Lichtso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pub trait Executor from program-runtime/src/executor.rs should be deleted as well.

program-runtime/src/loaded_programs.rs Outdated Show resolved Hide resolved
programs/bpf_loader/src/lib.rs Outdated Show resolved Hide resolved
program-runtime/src/loaded_programs.rs Show resolved Hide resolved
@Lichtso Lichtso mentioned this pull request Feb 16, 2023
Open
@pgarg66 pgarg66 requested a review from Lichtso February 16, 2023 21:59
@Lichtso Lichtso merged commit 3a4ba72 into solana-labs:master Feb 17, 2023
@pgarg66 pgarg66 deleted the remove-executors branch February 17, 2023 13:22
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Mar 12, 2023
@pgarg66 @nickfrosty
Remove executors trait and replace with LoadedProgram (solana-labs#30348
b9cc311 
)

* Remove executors trait and replace with LoadedProgram

* fill in deployment slot

* address review comments

* fix clippy warnings

* address review comments

* fix failures caught by sbf tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lichtso Lichtso Lichtso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Program Runtime v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgarg66 @Lichtso