Refactor - Remove process_instruction parameter first_instruction_account
#30579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/remove_process_instruction_first_instruction_account
branch
4 times, most recently
from
484ae48 to
2c8be3f
Compare
Lichtso
force-pushed
the
refactor/remove_process_instruction_first_instruction_account
branch
from
2c8be3f to
f136755
Compare
Lichtso
deleted the
refactor/remove_process_instruction_first_instruction_account
branch
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
…account` (solana-labs#30579) * Stops using first_instruction_account parameter in bpf_loader. * Removes first_instruction_account parameter from process_instruction().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
first_instruction_accountis being passed around to all built-in programs even though it is only used inbpf_loader.Summary of Changes
Moves the calculation of
first_instruction_accountfromInvokeContext::process_executable_chain()intobpf_loader::process_instruction_common().