Refactor - Remove first_instruction_account in bpf_loader
#30614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
reviewed
Mar 6, 2023
…truction(), process_loader_instruction() and write_program_data().
Lichtso
force-pushed
the
refactor/remove_first_instruction_account_in_bpf_loader
branch
from
cbd4b63 to
7b86646
Compare
pgarg66
approved these changes
Mar 8, 2023
Lichtso
deleted the
refactor/remove_first_instruction_account_in_bpf_loader
branch
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Mar 12, 2023
…-labs#30614) * Removes first_instruction_account from process_loader_upgradeable_instruction(), process_loader_instruction() and write_program_data(). * Removes first_instruction_account from process_instruction_common(). * Removes get_index_in_transaction() and try_borrow_account().
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The logic in
process_instruction_common()is quite complex and hard to understand. Additionally, we want to get rid ofprogram_indicesandtry_borrow_program_account, so their usage in the BPF loader needs to be minimized.There are five cases of what
program_accountinputsprocess_instruction_common()needs to handle:From that we can tell, that we only need to look at the last program in the chain, and only in case of the upgradeable loader also need the second last (the programdata account).
Summary of Changes
first_instruction_accountfromprocess_instruction_common(),process_loader_upgradeable_instruction(),process_loader_instruction()andwrite_program_data().get_index_in_transaction()andtry_borrow_account().