Forwarder: separate get_leader_and_addr #30922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apfitzge
force-pushed
the
refactor/forwarder-3
branch
from
9a5f9af
to
bc678b1
Compare
apfitzge
force-pushed
the
refactor/forwarder-3
branch
from
bc678b1
to
51cef29
Compare
Codecov Report
@@ Coverage Diff @@
## master #30922 +/- ##
========================================
Coverage 81.5% 81.5%
========================================
Files 727 727
Lines 205166 205436 +270
========================================
+ Hits 167295 167537 +242
- Misses 37871 37899 +28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Just cleaning up some of this in preparation for #30925.
Summary of Changes
Move
get_leader_and_addrinto a separate function so our forwarding function is less cluttered.Use "new" let-else rust syntax to return early
Fixes #