Add provisions to unload a program from the cache #31036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Apr 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #31036 +/- ##
========================================
Coverage 81.4% 81.5%
========================================
Files 728 728
Lines 206240 206379 +139
========================================
+ Hits 168079 168241 +162
+ Misses 38161 38138 -23 |
Lichtso
reviewed
Apr 10, 2023
Lichtso
reviewed
Apr 10, 2023
Lichtso
reviewed
Apr 10, 2023
|
Do we have tests that the transitions loaded -> unloaded and vice versa retain the usage statistics? |
Lichtso
reviewed
Apr 10, 2023
Added a new test in the latest commit. |
Lichtso
approved these changes
Apr 10, 2023
ryoqun
reviewed
Aug 25, 2023
| existing.usage_counter.load(Ordering::Relaxed), | ||
| Ordering::Relaxed, | ||
| ); | ||
| second_level.swap_remove(entry_index); |
There was a problem hiding this comment.
for the record: this newly-added instance of .swap_remove() is fixed at #32973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The program usage counts reset when it gets evicted from the cache.
Summary of Changes
Unloaded) for programs in the cache. When a program get evicted, it'll be replaced with this type. It'll keep track of program's usage count and other meta data.Fixes #