Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Moves bpf_loader registration into the runtime #31345

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Apr 25, 2023

Problem

All built-in programs should be registered in one place in the runtime, so that they can be refactored together.
Currently the bpf_loader built-ins are registered in the ledger. This also causes lots of redundant code in the setup of many tests.

Summary of Changes

  • Moves the registration of bpf_loader built-ins from the ledger into the runtime.
  • Removes bpf_loader built-ins registration in tests and benchmarks.
  • Removes declare_builtin!() of bpf_loader built-ins.
  • Removes built-ins from the SDK.

@Lichtso Lichtso force-pushed the refactor/moves_bpf_loader_registration_into_the_runtime branch 3 times, most recently from c576da7 to 5bbeb7b Compare April 25, 2023 19:55
@dmakarov dmakarov self-requested a review April 25, 2023 20:02
@Lichtso Lichtso force-pushed the refactor/moves_bpf_loader_registration_into_the_runtime branch from 5bbeb7b to c937204 Compare April 25, 2023 21:20
@Lichtso Lichtso force-pushed the refactor/moves_bpf_loader_registration_into_the_runtime branch 2 times, most recently from ca003c2 to 495f2dd Compare April 26, 2023 07:48
@Lichtso Lichtso force-pushed the refactor/moves_bpf_loader_registration_into_the_runtime branch from 495f2dd to cfc65da Compare April 26, 2023 08:15
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #31345 (cfc65da) into master (2dcdfff) will decrease coverage by 0.1%.
The diff coverage is 73.3%.

@@            Coverage Diff            @@
##           master   #31345     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         734      732      -2     
  Lines      207153   207159      +6     
=========================================
- Hits       168955   168888     -67     
- Misses      38198    38271     +73     

@Lichtso Lichtso merged commit c05d1d5 into solana-labs:master Apr 26, 2023
@Lichtso Lichtso deleted the refactor/moves_bpf_loader_registration_into_the_runtime branch April 26, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants