-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ci: use crates api to get owner list #31348
Conversation
a26509f
to
5046625
Compare
c8f9a54
to
d12bf84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result="$(cargo owner --list -q "$crate_name" --token "$CRATE_TOKEN" 2>&1)" | ||
if [[ $result =~ ^error ]]; then | ||
if [[ $result == *"Not Found"* ]]; then | ||
response=$(curl -s https://crates.io/api/v1/crates/"$crate_name"/owners) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we'll be subject to lower api rate-limits without the token, so we need to keep an eye on that
automerge label removed due to a CI failure |
(hi, i'm becoming a github action/workflow pro recently) well, this is expected. pr can't access to secretes as indicated below when kicked by |
yeah! thank you for the useful checking method! I think they changed something (like fix or publish new features) cuz our PR works fine with the same method/flow earlier. (like this one https://github.com/solana-labs/solana/actions/runs/4778963531/jobs/8495728916 ) and iirc when I implemented this feature, we could still get the secret correctly if we didn't modify the yml. (sounds risky today though) it just break on that day 🤔 |
Problem
seems that we can't get CRATE_TOKEN correctly in a PR.
Summary of Changes
just use curl to get crates owner list