Do not evict unloaded programs #31465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31465 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 731 731
Lines 208741 208675 -66
=========================================
- Hits 170020 169963 -57
+ Misses 38721 38712 -9 |
Lichtso
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Delay visible tombstones could be inferred by the presence of unloaded/loaded programs. Removing the explicit tombstone will simplify the handling of program management instructions.
Summary of Changes
This PR updates program eviction logic to not remove unloaded programs. This will enable the cache to always have either a loaded or unloaded cache entry for an upgraded program. This cache entry will imply that the older/outdated program is expired and should not be accessible after the given slot.
Fixes #