Update SBF programs tests to use bank from the correct slot #31491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
approved these changes
May 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #31491 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 731 731
Lines 208720 208729 +9
=========================================
- Hits 169980 169977 -3
- Misses 38740 38752 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using new LoadedPrograms cache causes test failures in SBF program tests.
Summary of Changes
The failing tests deploy programs and then send transactions to use the newly deployed/upgraded programs. The tests are using the same bank to deploy the program and execute the transactions. Due to delay visibility feature, the program is not effective for 1 slot after deployment. With the new cache (LoadedPrograms) this check uses bank's slot to compute the effective slot of the program.
This change advances the bank_client to the next slot after deployment of the programs.
Fixes #