More metrics for LoadedPrograms cache #31735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31735 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 736 736
Lines 205959 205982 +23
=======================================
+ Hits 168658 168682 +24
+ Misses 37301 37300 -1 |
Lichtso
reviewed
May 22, 2023
| self.entries.retain(|_, programs| !programs.is_empty()); | ||
| if self.entries.len() < num_programs_before_removal { | ||
| self.stats.empty_entries.fetch_add( | ||
| num_programs_before_removal.saturating_sub(self.entries.len()) as u64, |
There was a problem hiding this comment.
This is just about the keys of the first index and has nothing to do with entries of the second index, like all other metrics do?
There was a problem hiding this comment.
Yes, this is just counting how many programs were completely removed from the cache.
Lichtso
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing metrics datapoints for prune and a few other use-cases.
Summary of Changes
Added datapoint for Prune, and eviction.
Fixes #