Set deployment slot for non-upgradeable programs #31792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31792 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 737 737
Lines 205994 205995 +1
=======================================
+ Hits 168699 168722 +23
+ Misses 37295 37273 -22 |
Lichtso
approved these changes
May 24, 2023
jeffwashington
pushed a commit
to HaoranYi/solana
that referenced
this pull request
May 24, 2023
* Set deployment slot for non-upgradeable programs * fix sbf programs test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The deployment slot for the non-upgradeable programs is set to 0. It's causing issues if a tombstone gets added for these programs at a latter slot during deployment.
Summary of Changes
Set the deployment slot to current slot for such programs.
Fixes solana-labs/solana-web3.js#1308