Feature - Prune on feature set transition #31945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
changed the title
Lichtso
force-pushed
the
prune_feature_set_transition
branch
from
07972d1 to
4512f0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #31945 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 760 760
Lines 207407 207436 +29
=========================================
+ Hits 169958 169959 +1
- Misses 37449 37477 +28 |
pgarg66
previously approved these changes
Jun 2, 2023
Lichtso
force-pushed
the
prune_feature_set_transition
branch
from
4512f0e to
73cfe7c
Compare
Lichtso
force-pushed
the
prune_feature_set_transition
branch
from
73cfe7c to
e55a582
Compare
pgarg66
approved these changes
Jun 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Call create_program_runtime_environment() in Bank::apply_builtin_program_feature_transitions(). * Adds LoadedPrograms::prune_feature_set_transition(). (cherry picked from commit 89207a3)
Lichtso
added a commit
that referenced
this pull request
Jun 6, 2023
…#31988) Feature - Prune on feature set transition (#31945) * Call create_program_runtime_environment() in Bank::apply_builtin_program_feature_transitions(). * Adds LoadedPrograms::prune_feature_set_transition(). (cherry picked from commit 89207a3) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cached
program_runtime_environmentand all programs compiled against it can become outdated when a feature which involves the RBPF config is activated.Summary of Changes
create_program_runtime_environment()inBank::apply_builtin_program_feature_transitions().LoadedPrograms::prune_feature_set_transition().This PR does only ensures that the cache does not contain any outdated entries after the feature transition, it does not recompile them before the epoch boundary hits.