Filter vote accounts with no delegate from being selected in Rotation #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this hanging till @rob-solana figures out wallet updates and decides whether or not we need this. |
|
this is the right approach for Beacons. changing wallet and vote_api to support creation and initialization in one go is wasted work in the light of #3148, which means a rewrite of this stuff with this change, staking accounts with a self-referential delegate will not be considered in leader scheduling |
rob-solana
approved these changes
Mar 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #3224 +/- ##
========================================
+ Coverage 78.2% 81.7% +3.4%
========================================
Files 131 129 -2
Lines 20740 19847 -893
========================================
- Hits 16225 16217 -8
+ Misses 4515 3630 -885 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3224 +/- ##
========================================
+ Coverage 78.2% 81.7% +3.4%
========================================
Files 131 129 -2
Lines 20740 19847 -893
========================================
- Hits 16225 16217 -8
+ Misses 4515 3630 -885 |
pgarg66
referenced
this pull request
in pgarg66/solana
Mar 12, 2019
solana-grimes
pushed a commit
that referenced
this pull request
Mar 12, 2019
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since #3211, wallet can't fund and delegate accounts fast enough and the staking account id ends up in rotation and the network never recovers
Summary of Changes
Since a lot of the stake design is going to change in the coming weeks, this is a stopgap solution that disallows staking accounts that are "delegated" to themselves from being considered in rotation.
@garious, this or
we need to revive your PR with a single instruction to create and delegatewallet commands need to usevote_transaction::new_account_with_delegate