Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize and store PRv2 environment in cache #32812

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Aug 11, 2023

Problem

Program runtime V2 environment is created every time a program is loaded. This can be optimized.

Summary of Changes

Store the environment in the cache.
Another refactor is needed to reuse the cached environment.

Fixes #

@pgarg66 pgarg66 requested a review from Lichtso August 11, 2023 17:45
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #32812 (7284ad2) into master (c73a56f) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is 72.4%.

❗ Current head 7284ad2 differs from pull request most recent head b8f0b92. Consider uploading reports for the commit b8f0b92 to get more accurate results

@@            Coverage Diff            @@
##           master   #32812     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         785      785             
  Lines      211911   211928     +17     
=========================================
- Hits       173818   173804     -14     
- Misses      38093    38124     +31     

runtime/src/bank.rs Outdated Show resolved Hide resolved
@pgarg66 pgarg66 marked this pull request as ready for review August 11, 2023 18:03
@pgarg66 pgarg66 added the automerge Merge this Pull Request automatically once CI passes label Aug 11, 2023
@mergify mergify bot merged commit a1a0829 into solana-labs:master Aug 11, 2023
@pgarg66 pgarg66 deleted the prv2-env branch August 11, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants