-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New exec code path rebased #33070
New exec code path rebased #33070
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #33070 +/- ##
=========================================
- Coverage 81.5% 81.3% -0.3%
=========================================
Files 834 835 +1
Lines 224876 226614 +1738
=========================================
+ Hits 183496 184448 +952
- Misses 41380 42166 +786 |
5089205
to
322154a
Compare
scheduler-pool/src/lib.rs
Outdated
fn pool(&self) -> InstalledSchedulerPoolArc<SEA> { | ||
self.pool.clone() | ||
fn return_to_pool(self: Box<Self>) { | ||
self.pool.clone().return_scheduler(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the .clone()
can be removed, btw... ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, never mind. i can't. borrow checker would complain...
scheduler-pool/src/lib.rs
Outdated
pub fn return_scheduler(&self, scheduler: Box<dyn InstalledScheduler<SEA>>) { | ||
assert!(scheduler.context().is_none()); | ||
|
||
self.schedulers | ||
.lock() | ||
.expect("not poisoned") | ||
.push(scheduler); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here 2
runtime/src/bank.rs
Outdated
self.loaded_programs_cache | ||
.write() | ||
.unwrap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
// this cuts circular references of BankForks... | ||
root_bank | ||
.loaded_programs_cache | ||
.write() | ||
.unwrap() | ||
.unset_fork_graph(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file!
This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave |
this is yet another pr for unified scheduler (prev: #31239)
todo
--unified-scheduler-handler-threads=N
--unified-scheduler-individual-transaction-timings
?