This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor - LoadedPrograms
#33482
Merged
Refactor - LoadedPrograms
#33482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/loaded_programs
branch
from
76282cf to
cd3d686
Compare
Codecov Report
@@ Coverage Diff @@
## master #33482 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 802 802
Lines 217801 217802 +1
=========================================
- Hits 178110 178102 -8
- Misses 39691 39700 +9 |
dmakarov
reviewed
Oct 2, 2023
dmakarov
approved these changes
Oct 2, 2023
pgarg66
approved these changes
Oct 2, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Adds type ProgramRuntimeEnvironment. * Moves LoadedPrograms::remove_expired_entries() into LoadedPrograms::prune(). * Adds Stats::prunes_environment and renames Stats::prunes_orphan and Stats::prunes_expired. * Adds LoadedPrograms::latest_root_epoch. * Typo fix, authored-by: Dmitri Makarov <dmakarov@users.noreply.github.com> (cherry picked from commit 8033be3)
Lichtso
added a commit
that referenced
this pull request
Oct 3, 2023
* Adds type ProgramRuntimeEnvironment. * Moves LoadedPrograms::remove_expired_entries() into LoadedPrograms::prune(). * Adds Stats::prunes_environment and renames Stats::prunes_orphan and Stats::prunes_expired. * Adds LoadedPrograms::latest_root_epoch. * Typo fix, authored-by: Dmitri Makarov <dmakarov@users.noreply.github.com> (cherry picked from commit 8033be3)
Lichtso
added a commit
that referenced
this pull request
Oct 3, 2023
Refactor - `LoadedPrograms` (#33482) * Adds type ProgramRuntimeEnvironment. * Moves LoadedPrograms::remove_expired_entries() into LoadedPrograms::prune(). * Adds Stats::prunes_environment and renames Stats::prunes_orphan and Stats::prunes_expired. * Adds LoadedPrograms::latest_root_epoch. * Typo fix, authored-by: Dmitri Makarov <dmakarov@users.noreply.github.com> (cherry picked from commit 8033be3) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Preparation for #33477.
Summary of Changes
ProgramRuntimeEnvironment: For slightly improved code readability.LoadedPrograms::remove_expired_entries()intoLoadedPrograms::prune(): As an optimization as we don't need toretain/collectthe secondary index level twice.Stats::prunes_environmentand renamesStats::prunes_orphanandStats::prunes_expired: So that all three reasons for pruning entries on rerooting have the same naming scheme.LoadedPrograms::latest_root_epoch: To detect the first rerooting after an epoch boundary, ending the recompilation phase.