Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blockstore-purge delete_files_in_range_us metric #33512

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Oct 3, 2023

Problem

This field was being filled with the wrong value

This field was being filled with the wrong field
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #33512 (b23e49e) into master (3008cd8) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #33512   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         802      802           
  Lines      217835   217835           
=======================================
+ Hits       178123   178126    +3     
+ Misses      39712    39709    -3     

Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG. Thanks for spotting this!

@steviez steviez merged commit 666ce9b into solana-labs:master Oct 5, 2023
16 checks passed
@steviez steviez deleted the bstore_purge_metric branch October 5, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants