Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses IntSet for ShrinkCandidates #33522

Merged

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Oct 4, 2023

Problem

#33521 added solana-nohash-hasher. ShrinkCandidates is a list of slots, and doesn't need to be cryptographically secure. This will make using the shrink candidates faster.

Summary of Changes

Uses IntSet for ShrinkCandidates

@brooksprumo brooksprumo added the noCI Suppress CI on this Pull Request label Oct 4, 2023
@brooksprumo brooksprumo self-assigned this Oct 4, 2023
@brooksprumo brooksprumo force-pushed the nohash/shrink-candidates branch from 7a1f1c5 to 7214286 Compare October 4, 2023 15:59
@brooksprumo brooksprumo added CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request labels Oct 4, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 4, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 4, 2023 16:29
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #33522 (7214286) into master (ec1115e) will decrease coverage by 0.2%.
Report is 1003 commits behind head on master.
The diff coverage is 88.0%.

@@            Coverage Diff            @@
##           master   #33522     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.2%     
=========================================
  Files         766      803     +37     
  Lines      209028   217899   +8871     
=========================================
+ Hits       171148   178137   +6989     
- Misses      37880    39762   +1882     

@brooksprumo brooksprumo merged commit d41fa34 into solana-labs:master Oct 4, 2023
7 of 16 checks passed
@brooksprumo brooksprumo deleted the nohash/shrink-candidates branch October 4, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants