This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add compute budget limits to TransactionMeta with TTL #33572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… itself, so CB instructions can be processed elsewhere without involving CompueBudget
* Add Database::compact_range_cf method * Add test of CompactionFilter purge
ci: move stable-perf to nightly pipeline
These entries were found to improve compaction performance when LedgerCleanupService was performing direct compactions on each primary index. Cleaning by primary index has been deprecated for a while, and as such, these dummy entries are no longer needed and can be removed.
…ana-labs#33498) * Adjust test_purge_transaction_status_exact to test slots that cross primary indexes * Minimize deletes by checking the primary-index range * Fix test_purge_special_columns_compaction_filter
* chore: remove unused deps * ci: increase regression of build redundancy
* Define generic AbiExample for OnceLock
* Guard with cfg...
cargo-test-sbf (governance/addin-mock/program, governance/program):
error[E0658]: use of unstable library feature 'once_cell'
--> src/abi_example.rs:559:36
|
559 | impl<T: AbiExample> AbiExample for std::sync::OnceLock<T> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #74465 <rust-lang/rust#74465> for more information
= help: add `#![feature(once_cell)]` to the crate attributes to enable
* Add error messages for BlockstoreError * display underlying errors * address PR comments: remove unnecessary error from msg Co-authored-by: steviez <stevecz@umich.edu> * fix typo Co-authored-by: steviez <stevecz@umich.edu> --------- Co-authored-by: steviez <stevecz@umich.edu>
… that comes with metadata
…ing traits for transacion_meta
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a draft based on #33513 and #33471
Next step: make
ComputeBudgetLimitspart of StaticTransactionMeta, so the calls toprocess_compute_budget_instructions()can be reduced to once (per epoch).Summary of Changes
ComputeBudgetLimitsto TransactionMeta with TTL (max_age_slot) to invalidates cached value when new epoch (due to potential feature_set change)RuntiemTransactiontypes to create-then-readonly pattern to make it safe for multi-threads,renew_from()to discard expiredRuntimeTransactionand create one instance when new epoch.Fixes #