Cleanup - Feature Gate of enable_early_verification_of_account_modifications
#33579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
cleanup/enable_early_verification_of_account_modifications
branch
4 times, most recently
from
1069ed7 to
ff44e4d
Compare
Lichtso
force-pushed
the
cleanup/enable_early_verification_of_account_modifications
branch
from
ff44e4d to
9b478a4
Compare
…difications: - Removes PreAccount - Removes InvokeContext::pre_accounts and InvokeContext::rent - Removes InvokeContext::verify() and InvokeContext::verify_and_update() - Removes TransactionContext::is_early_verification_of_account_modifications_enabled() - Removes TransactionAccounts::is_early_verification_of_account_modifications_enabled - No longer optional: TransactionContext::rent
Lichtso
force-pushed
the
cleanup/enable_early_verification_of_account_modifications
branch
from
9b478a4 to
afefd0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #33579 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 807 806 -1
Lines 217999 217525 -474
=========================================
- Hits 178525 178124 -401
+ Misses 39474 39401 -73 |
pgarg66
approved these changes
Oct 10, 2023
Lichtso
deleted the
cleanup/enable_early_verification_of_account_modifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#26589 has been activated on all three clusters.
Summary of Changes
PreAccountInvokeContext::pre_accountsandInvokeContext::rentInvokeContext::verify()andInvokeContext::verify_and_update()TransactionContext::is_early_verification_of_account_modifications_enabled()TransactionAccounts::is_early_verification_of_account_modifications_enabledTransactionContext::rent